Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test_positive_capsule_certs_generate_with_special_char #17521

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

jameerpathan111
Copy link
Contributor

@jameerpathan111 jameerpathan111 commented Feb 6, 2025

Problem Statement

  • test_positive_capsule_certs_generate_with_special_char is failing with an assertion error.

Solution

  • Remove the test as the output of the command no longer has org name.

Related Issues

  • SAT-30946

@jameerpathan111 jameerpathan111 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Feb 6, 2025
@jameerpathan111 jameerpathan111 self-assigned this Feb 6, 2025
@jameerpathan111 jameerpathan111 requested a review from a team as a code owner February 6, 2025 07:31
@jameerpathan111
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_capsule.py -k test_positive_capsule_certs_generate_with_special_char

@evgeni
Copy link
Member

evgeni commented Feb 6, 2025

What is this test supposed to ensure? Looking at https://bugzilla.redhat.com/show_bug.cgi?id=1908841 and the test structure, it seems to test that we can generate certs when the initial org has special chars in its name.

However, we do not emit the org name in the output (which is what triggered the bug) since theforeman/foreman-installer@a34f962 so by that logic that test can be dropped?

(that certs-generate works otherwise is ensured by the normal "deploy capsule" certs, right?)

@jameerpathan111
Copy link
Contributor Author

What is this test supposed to ensure? Looking at https://bugzilla.redhat.com/show_bug.cgi?id=1908841 and the test structure, it seems to test that we can generate certs when the initial org has special chars in its name.

However, we do not emit the org name in the output (which is what triggered the bug) since theforeman/foreman-installer@a34f962 so by that logic that test can be dropped?

(that certs-generate works otherwise is ensured by the normal "deploy capsule" certs, right?)

You're right. Let's remove the test:D

@jameerpathan111 jameerpathan111 requested a review from a team as a code owner February 6, 2025 08:06
@jameerpathan111 jameerpathan111 changed the title Fix test_positive_capsule_certs_generate_with_special_char Remove test_positive_capsule_certs_generate_with_special_char Feb 6, 2025
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10086
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_capsule.py -k test_positive_capsule_certs_generate_with_special_char --external-logging
Test Result : ================= 1 passed, 13 warnings in 1967.89s (0:32:47) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 6, 2025
@Gauravtalreja1 Gauravtalreja1 merged commit 4a30635 into SatelliteQE:master Feb 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants